screenShield: Connect to the actor's show signal instead of using BEFORE_REDRAW

This should make sure that we grab at the right time while at the same time
not break focus handling.

https://bugzilla.gnome.org/show_bug.cgi?id=684650

diff --git a/js/ui/screenShield.js b/js/ui/screenShield.js
index 07e450f8fcb0d27370937d7ea93bc92e1dff9a24..e10ef346ba64746ab33a92f952cfc0a6d84fd27d 100644 (file)
--- a/js/ui/screenShield.js
+++ b/js/ui/screenShield.js
@@ -579,13 +579,14 @@ const ScreenShield = new Lang.Class({
     showDialog: function() {
         // Ensure that the stage window is mapped, before taking a grab
         // otherwise X errors out
-        Meta.later_add(Meta.LaterType.BEFORE_REDRAW, Lang.bind(this, function() {
+        let actorShownId = 0;
+        actorShownId = this.actor.connect('show', Lang.bind(this, function() {
             if (!this._isModal) {
                 Main.pushModal(this.actor);
                 this._isModal = true;
             }
 
-            return false;
+            this.actor.disconnect(actorShownId);
         }));
 
         this.actor.show();